fix: make only errors have non-zero exit code from server/client (#1204)

Fix 1174 (#1175)

* fix: Daywalkr - Fix for guild bank OOBs

* fix: Daywalkr - Add migration to prevent possible guilds having too many bank slots after change; fix event command for adding guild bank slots

* chore: Daywalkr - 1174 code review

* chore: Review; cleanup weird contextmodelsnahpshot change

fix: Daywalkr - Bounds check (#1171) (#1172)

Authored-by: AVild <ajv2324@gmail.com>

I just copied it like a lazy git.

fix: (Daywalkr) Fix for modifying a game object but not saving it in our server packet handler when requesting to save a quest task completion event (#1143)

fix: Daywalkr - OOB exception in Entity update due to spell cast cancelling (#1124)

Fix: removes hardcoded ComboBox sound effects (#1098)

* Removes default hardcoded values of ComboBox sound effects.

Explanation: ComboBox sound effects shouldn't be overwritten by default hardcoded values, they should consider the user's input from the Json files, it doesn't matter if the value is null or the established sound effect doesn't exists since this isn't an issue for Gwen.

FIX: 1087 (Step backward/forward do not work) (#1099)

* Daywalkr: Hotfix for step forward/step backward movement commands not working

* code review

Fixes a visual glitch when moving elements within the hotbars. (#1089)

[GWEN] FIX #1031: Control Base now keeps track of sound instance it plays (#1032)

* Daywalkr: Gwen Control Base now keeps track of sound instance it plays; resolves 1031

* Daywalkr: Update to support multiple sound playback in Gwen elements

* Daywalkr: Delegated sound playing to the canvas class, as per Cheshire's suggestion

* Daywalkr: Remove dead code

Inventory Stack limit respected when pulling out of bank (#1075)

* Alex: Fix bug where you could withdraw a larger stack than the inventory stack limit allowed

* Alex: Add myself to authors :>

* Alex: Nevermind not yet

Alex: Fix bug in 'CanGiveItem' where we were not considering stackable properties correctly (#1076)

Fix: "Player is Busy" on Party Invite. (#1084)

* Fix: "Player is Busy" on Party Invite.

* Should resolve #1083

* Review Changes

* We already had a method for IsBusy(), so i've moved in: Trading.Requester, PartyRequester and FriendRequester.

* IsBusy() had a Inconsistent body style: changed it to expression body.

* IsBusy() is only used within the Player class, so i've made it private.

* Replaced the checks for Trading.Requester, PartyRequester and FriendRequester by !IsBusy()

* Moved the the FriendRequester nullifier to the right place in the friendrequest packet handler, which fixes the "isbusy" issue with party invites.

Fix issues where DoTs would stack multiple times for the same spell (#1078)

* Alex: Fix bug with DoTs not stacking across players

* Alex: Code review

Check whether the index we are attempting to request data for is valid (#1023)

Use correct variable Id for HasFreeInventorySlots condition (#978)

save output when loading Gui Json files unless loading from cache (#954)

Fixes map updates when metrics is false. (#1005)

* Should resolve #855

Fix for unused colours for quests. (#1008)

Should resolve #1004

Fix #946 - Formula to be considered before verification of base damage (#958)

Fix when trying to swap targets HP and MP and when target MPs defense transform MP damaging in MP healing (#949)

Restore Fill and Erase functionality for Attributes in the map editor (#944)

Stop (partially) destroying and fully recreating the bank window each use, was leaving orphaned Gwen objects around causing a memory leak. (#933)

FIX-864: AV - Crafts editor now correctly updates common event combo box (#904)

fix: (Daywalkr) - Fix so inventory changed common events fire when dropping items (#1145)

fix: (Daywalkr) Fix for modifying a game object but not saving it in our server packet handler when requesting to save a quest task completion event (#1143)

fix: Daywalkr - OOB exception in Entity update due to spell cast cancelling (#1124)

Fix: removes hardcoded ComboBox sound effects (#1098)

* Removes default hardcoded values of ComboBox sound effects.

Explanation: ComboBox sound effects shouldn't be overwritten by default hardcoded values, they should consider the user's input from the Json files, it doesn't matter if the value is null or the established sound effect doesn't exists since this isn't an issue for Gwen.

FIX: 1087 (Step backward/forward do not work) (#1099)

* Daywalkr: Hotfix for step forward/step backward movement commands not working

* code review

Fixes a visual glitch when moving elements within the hotbars. (#1089)

[GWEN] FIX #1031: Control Base now keeps track of sound instance it plays (#1032)

* Daywalkr: Gwen Control Base now keeps track of sound instance it plays; resolves 1031

* Daywalkr: Update to support multiple sound playback in Gwen elements

* Daywalkr: Delegated sound playing to the canvas class, as per Cheshire's suggestion

* Daywalkr: Remove dead code

Inventory Stack limit respected when pulling out of bank (#1075)

* Alex: Fix bug where you could withdraw a larger stack than the inventory stack limit allowed

* Alex: Add myself to authors :>

* Alex: Nevermind not yet

Alex: Fix bug in 'CanGiveItem' where we were not considering stackable properties correctly (#1076)

Fix: "Player is Busy" on Party Invite. (#1084)

* Fix: "Player is Busy" on Party Invite.

* Should resolve #1083

* Review Changes

* We already had a method for IsBusy(), so i've moved in: Trading.Requester, PartyRequester and FriendRequester.

* IsBusy() had a Inconsistent body style: changed it to expression body.

* IsBusy() is only used within the Player class, so i've made it private.

* Replaced the checks for Trading.Requester, PartyRequester and FriendRequester by !IsBusy()

* Moved the the FriendRequester nullifier to the right place in the friendrequest packet handler, which fixes the "isbusy" issue with party invites.

Fix issues where DoTs would stack multiple times for the same spell (#1078)

* Alex: Fix bug with DoTs not stacking across players

* Alex: Code review

Check whether the index we are attempting to request data for is valid (#1023)

Use correct variable Id for HasFreeInventorySlots condition (#978)

save output when loading Gui Json files unless loading from cache (#954)

Fixes map updates when metrics is false. (#1005)

* Should resolve #855

Fix for unused colours for quests. (#1008)

Should resolve #1004

Fix #946 - Formula to be considered before verification of base damage (#958)

Fix when trying to swap targets HP and MP and when target MPs defense transform MP damaging in MP healing (#949)

Don't delete our target as soon as we try and draw a hidden entity (#943)

Restore Fill and Erase functionality for Attributes in the map editor (#944)

[Fix] Chatbox BlankMsgs Behaviour with SpamCheck. (#938)

Forced Pushed Back & applied all changes and review changes in one commit.

Stop (partially) destroying and fully recreating the bank window each use, was leaving orphaned Gwen objects around causing a memory leak. (#933)

FIX-864: AV - Crafts editor now correctly updates common event combo box (#904)

Adding myself as a contributor (#1158) (#1159)

chore: update issue templates (#1127)

* Update enhancement_idea.md

* Update bug_report.md

* Update feature_request.md

Update README.md (#707)

Updated README.md (#540)

* Updated README.md

Updated the source code compilation information (which was outdated, VS 2017 isn't capable to build the current solution anymore).

The URL linked to the "Getting Started" documentation has been updated as well.

* Update README.md

* Update AUTHORS.md

Added myself as contributor.

Real Name: Fernando Arzola Lagos.

AKA: Arufonsu - https://github.com/Arufonsu

chore: documentation updates (#1105)

* chore: delete maintainers.md and update authors.md

* chore: document versioning

* chore: document security procedures

* chore: document contribution guidelines

Daywalkr: Add myself to authors; signed (#1079)

Update README.md (#707)

Updated README.md (#540)

* Updated README.md

Updated the source code compilation information (which was outdated, VS 2017 isn't capable to build the current solution anymore).

The URL linked to the "Getting Started" documentation has been updated as well.

* Update README.md

* Update AUTHORS.md

Added myself as contributor.

Real Name: Fernando Arzola Lagos.

AKA: Arufonsu - https://github.com/Arufonsu

chore: cleanup nuget.config (#1106)

fix: remove redundant call (#1071)

fix: remove groupby in get logs/trade (#1066)

* fix: remove groupby in get logs/trade

* fix: groupby but after reducing loaded set

fix: character select should not mark user offline (#1060)

fix(plugins): fixed client plugin packet sender (#882)

fix: fix broken exclusions

missing ; in exclusions

updated packages in Examples

improved package build script

fix: exclude isf binary from targets

Intersect.Server.Framework.dll was being copied into the build directory when it should not have been

Add targets directory to the solution so it's easier to edit them in the IDE

feat: add packet sending for client plugins (#878)

* feat: enable sending packets from client plugins

* fix: packet handler is null until after start

* feat: add local package deploy to package script

chore: update nuget packages

fix: add .idea to gitignore

fix: fix plugin config initializer (#867)

Fix 725: Order all game object lists alphabetically where we cannot display folders (#839)

Fix item duplication angle when trying to pickup map items with a full inventory (#840)

Added lifecycle Update event for Client (#856)

* Added lifecycle Update event

* Renamed "LifecycleUpdate" to "GameUpdate" to disambiguate from "LifecycleChangeState"

Add Common Event Triggers to Crafting Items (#813)

* Initial Commit

Added Event field to Craft Editor - Works but doesn't trigger on successful craft.

* StartCommonEvent Trigger Added

Can now start the common event when a craft is successful

* Potential Issue fixed

Added if case to check if Craft HAS an event to begin with.

* DB Migration Integrated

Not 100% sure if this actually works as intended but worked on my end.

* Added Localization as per Cheshire

* Update Strings.cs

* Renamed Function and Moved Above Line 454

As per JC's request

* Update frmCrafts.cs

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Shop & Crafting Table list sorting (#838)

* Allow sorting of sold items in shops

* Allow sorting of crafting table item list

* Added null value handler to Strings.CraftingTableEditor

* Added null value handling to Strings.ShopEditor

Added buying and selling sound effects to shops (#837)

* Added buying and selling sound effects to shops

* Update Strings.cs

Added a craft all button, resolves #822 (#836)

* Added a craft all button, resolves #822

* Update Strings.cs

Fix 779: Stop players from PMing themselves. (#835)

Fix 781: Targeting of steathy and event hidden players. (#834)

Fix transform effects not returning back to their original sprite. (#833)

Fix 803 by allowing crit dmg multipliers to be set to 2 decimal points in various editors (#832)

Fix 807 by render crafting item and ingredient color hues (#831)

Also uses the craft name in the crafting list instead of the item name.

In cases where the craft might make multiple quantities or something we give more control over the listing names to the developers.

Fixes condition negation for most conditionals. (#830)

Fixes 817 by having client respect blocked animation attribute tiles (#828)

Fix compile error due to merging the bonus party exp edit where the variable name didn't match. (#829)

Bonify XP Party for Each Member (#773)

* Bonify XP Party for Each Member

Its Resolves: #749

Percentage configured on the gain server.

Ex: 10 = 10%

Monster gives 1000 XP.

1 player, alone, without a party, will win 1000 by killing him.

2 players in a party, will kill this monster.

The Exp that will be divided will be +20%

Then, the monster will now divide 1200 XP, totaling a division of 600 XP for each member.

In short, for each additional member in a group you will gain + 10% xp on top of the xp to be divided for EVERYONE.

The particular EXP I cannot change because there is already a configuration in the items that can add XP individual bonus for each one.

* Changed BonusExperiencePercentPerMember...

Changed to BonusExperiencePercentPerMember for more clarity

* Changed name var

Changed to: bonusExp

* Update Player.cs

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Resolves 794 by allowing items to be picked up from the map even if you cannot hold the entire amount (#795)

* Resolves 794 by allowing items to be picked up from the map until the inventory is full (even if you don't grab the entire stack)

* Thanks Joyce -_-

* Retain error message

Resolve chatbox scrolling issues. (#816)

Resolves 819 by not allowing the engine to give player items with quantities <= 0 (#825)

Fix 824 - Do not allow escape to close crafting window while crafting. (#826)

Fix 823 by retaining item hues when dragging (#827)

FIXES AscensionGameDev/Intersect-Engine#798: Healthbar Scaling Fix (#785)

* Daywalkr: Fixed a bug where health/shield bars did not render at the correct width when tile sizes were configured to be different.

* #798: Updated so that shield bars also scale correctly across tile sizes.

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Fix index out of range crash when checking equipment stats (#802)

* Fix index out of range crash when checking equipment stats for equipment that has changed/been removed

* Update Player.cs

Fixes server crash when input variable command has no variable (#793)

Adds custom error messages when requirements are not met to use items, cast spells, or harvest resources. (#791)

Fix fleeing npcs from running past their reset radius and instantly restoring health. (#789)

fix: update example plugins and packages (#845)

Hide quantity on single-stackable items (#805)

* AV: Resolves issue 804

* 804: Remove the config option for hiding stacks < 2 in size

* 804: Added 'hidestack at 1' logic to bags as well; updated logic to include negative/0 quantities

* 804: Updated logic to appear in loot and trade windows as well

Merge pull request #776 from AscensionGameDev/updatingPrerelease

Updating prerelease

Fixes #759 where variable inputs failed to trigger variable changed common events (#772)

Fixes #734 by not crashing the server if multiple variables have the same textIds. (#771)

Fixed npc common events on death (for party members) not running (#770)

Resolves #754 by adding a checkbox in the item editor for guild banking (#769)

Fix 753 part2 (#768)

* Hide the guild invite button in the ui if they are already in a guild

* Added the message on the client side as well

Fixes #764 but spawning map animations based on y rendering (#767)

Reset stat point allocations event command (#765)

Fix compile errors resulting from merging #762 (#766)

Guild Invite Fix (#762)

Option to Loss Exp When Die (#748)

* Option to Loss Exp When Die

Resolves: #722

* Removed Boolean of XP Loss

* Changing condition to check if player will loss XP

* Update ExpLoss variable

* ExpLossOnDeathPercent variable replaced...

* Add option to decide how the exp will be take.

Thanks for suggestions,

* Check condition of xp loss mode

This will check if the percentage is above 0, then it will check the XP loss mode, if based on the total XP, or current XP acquired.

* Add line break

* Addes tabs every line

* Add line break before function

Hotkey for Guild Window (#738)

* Enabled ESC to Close Guild Window

Resolves #729

* Revert "Enabled ESC to Close Guild Window"

This reverts commit 221ac220c816712a91a123f570819cb94bc331a5.

* Enabled Hotkey for Guild

Added hotkey entry for opening the Guild Window.

Not 100% sure about the JSON generation but tested in game with an edited OptionsMenu.json.

* Reordered Things

As requested by JC

* Update Strings.cs

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Guild logging and endpoints (#739)

* Added regex filters to check for valid guild names

* Added logging of guild chat messages

* Added api endpoints for renaming guilds, viewing guild members/banks, and managing guild members/ranks

* Add guild history/activity logging

fix casing issue for VS Mac (#752)

Co-authored-by: Jebb Burditt <jebb.burditt@frozenmountain.com>

Enabled ESC to Close Guild Window (#737)

Resolves #729

Trade logging and endpoints (#732)

* Fix a bug where traded items do not retain the stats of the items offered.

* Added trade logging and api endpoints to view/query trades from the logging db

Add item stack caps (#728)

* Add Inventory Item Stack Caps

* Rewrite the bank logic to function closer to the inventory logic and take advantage of stack limits.

* Add editor portion, fix bug that allowed item duping

Add item bankable checks to the second TryDeposit method (#726)

Make item binding options more granular (#720)

* Make item binding options more granular

Added the following options to replace Bound:

- CanDrop

- CanDropOnDeath

- CanTrade

- CanSell

- CanBank

- CanBag

* Replace CanDropOnDeath with item specific drop chances, defaulting to server config on new items

* Fix an issue with downgrading

* Move bankable check outside of bank lock

Hide chatbubbles when stealthed, fix character not going transparent when stealthed (#723)

Fix sqlite migration by allowing color field to be null

Update README.md (#706)

Fix abbreviated quantity strings not rendering in bags/bank (#713)

Fix resource editor & event editor icon (#712)

* Populate common events and tool types on resource editor load

* Also fix event editor icon while we're here

Fixes ghost entities from appearing when kicking/promoting/demoting offline players in guilds (#710)

Make the engine not dependent upon default text values in the db in order to resolve migration issues adding color columns. (#708)

Track player online times in the db via a ulong representing seconds instead of Time fields due to mysql time limitation of 838 hours (#704)

Added categories for the quest log, quest order values, and more (#693)

- Ability to hide quests which have not been started until start reqs are met.

Remove Arena PvP event trigger limitations, add Condition to check for Zone Types (#698)

feat: add utility methods and props to point/tex (#697)

Co-authored-by: Robert Lodico <lodico.rj@gmail.com>

Guilds v1 (#689)

* Guilds V1

* Removed partial guild classes and merged with existing base engine classes.

* Make the lowest rank Newbie instead of Probationary so it fits in the guild guild ui

* Fix demotion options showing up for users

* Fixed a bug where clients would crash trying to pickup/gather items when inventories were full

Fix item names drawing when hovering over the proper coordinates on ANY map (#695)

Added options to wait until event pictures are closed, and auto hide after X time options as well (#691)

Fix potential crash on logout when searching for expired cooldowns to wipe (#688)

Allow casting to occur while already moving when MovementCancelsCast is false (#686)

Fix player shield bar rendering when it shouldn't and expanding incorrectly. (#685)

Speed up editor listing and searching, also cleanup code in engine editors (#682)

Resolves bug where common events with equip/unequip trigger were running despite no actual equipment changes (#677)

Client performance tweaks (#663)

* Fix excessive disk usage loading assets when sprites haven't changed

* Only set the interface count debug label when opening the window, because the linq query takes a lot of processing time

* Tweaks to shaders & lighting so we can batch lights with matching settings and improve rendering performance.

Reduce and/or remove resx dependencies (#671)

A lot of these had duplicated info for form icons, and other duplicate resources which are not needed. Cutting down on these files should reduce merge conflicts going forward.

Fix texture packing memory leak by not loading full MonoGame textures while calculating rects (#680)

Added partials to most classes that mods would want to expand on (#675)

* Added partials to most classes that mods would want to expand on, and would benefit from doing so in different/clean files to avoid merge conflicts

* I guess these forgot to save -_- (this commit will be squashed away)

Small UI Tweaks (#673)

* Move chatbox text cursor to end of line when auto inputting text

* Allow naming ui menus so their properties can be loaded from json files

* Menu name parameter should be optional

* Cache loaded json ui files so reading them later is instant (ie for loading banks)

Fix common events not starting when the first page of conditions are not met (#669)

Fixes exp bar not updating and showing full xp when you have 0 (#668)

Fix npcs not resetting when pulled outside their reset radius (#665)

Do not spawn more projectiles if the spawn itself is being disposed already (#662)

Fix event trigger variable selection offset when reloading event editor (#660)

Added map critter attributes (#656)

* Added map critter attributes which are client sided, non interactable roaming npcs

* Update Critter.cs

New common event triggers! (#658)

On Equip/Unequip

On Player Variable Change (specific variable selected in common event editor)

On Server Variable Change (specific variable selected in common event editor)

Batch movement, action message, and animation packets (#657)

* Batch entity movements and send them with each map update

* Update PacketSender.cs

* Batch and send groups of action messages together

* Update MapActionMessages.cs

* Batch animation packets, added packet batching options to server config

Option for map animation attributes to also be blocked tiles (#655)

Fixes Player.ShowLevelByName not working (#647)

Added options to ignore cooldown reduction for items & spells. (#641)

If ignore cdr is checked then cdr will not be applied for the group when that particular item/spell is used.

Fixes 596 by properly handling invalid packets (#637)

Added more npc reset options (#645)

ContinuouslyResetVitalsAndStatuses (true/false) will determine whether the npc restores hp/resets statuses while they work their way back to their reset point.

AllowEngagingWhileResetting (true/false) will determine if a npc that is resetting can be engaged again if their new attacker is within the reset radius.

Added option in the npc editor to drop individualized loot for all attackers (#642)

* Added option in the npc editor to drop individualized loot for all attackers

Otherwise default loot drop behavior is in effect.

There is a server config option so that if you are using the individualized loot option for an npc a killers party members can automatically be included in the loot drops.

* Added the db migration and a semicolon

Fixes event parameter text replacements (#640)

Prevents crash when trying to render a tooltip while it's value is reset to null/empty string (#639)

Resolves 598 (at least partially) by not casting npc single target spells unless the target is in range (#638)

Reset TargetBox when switching targets so that it updates correctly (#636)

Resolves #634 by sending vital updates when only the max vital changes (#635)

Fix projectile responsiveness/delay on server processing (#633)

Track game stats & metrics + api reporting (#630)

* Server performance, networking, etc metrics tracking

* Better/less stressful way to calculate autorun events in play

* Whoops, forgot this.

* Added commands to enable/disable metrics collection via the command line, reduced some metrics on packet handling

* Stop all potentially expensive metric operations when metrics collection is disabled.

* Reduce number of queries to DateTime.UtcNow by only checking when Environment.TickCount changes.

* Clear metrics snapshot when disabling metrics

* Track top 10 most sent and received network packets for each collection window

* Added more metrics tracking to threadpools, and more configuration for the .net managed threadpool

* Update MetricsRoot.cs

* Stat/metric tracking performance is much better with our own histogram class instead of using AppMetrics

* Delete metrics2.patch

* Rename player save threads to just database threads. Stop saving server variables in realtime, instead update the db at an interval or server shutdown.

* Update UserActivityHistory.cs

* Save chat history using the database thread pool

* Update LogicService.LogicThread.cs

Check if user is null before checking it's property -_- (#629)

Fix bug for using bag, trying to store or retrive items form a bag don't work (#608)

Added extra sort options for users, players, and the online list (#628)

Add Chat Logging & Logging Api Endpoints (#627)

* Working chat logging, thanks Marsh!

* Whoops, committed this to the wrong branch

* Add logs endpoint to the API, allow fetching of chat logs, ip logs, and activity logs from the api

Track user playtime, last ip, and registration dates. Also track character playtime and creation dates. (#626)

Extended API Endpoints (#602)

* Added searching and sorting to Users.List()

Cannot use compiled queries entirely for this yet. Maybe if we upgrade to EF Core 5... sorting would have to be done by referencing properties (like User.Name) with EF.Property<string>(User, "Name") BUT then the order is off due to not handling case sensitivity correctly which can potentially be resolved by specifying collations which isn't supported until EF Core 5.

* Sorting/searching of players. Doing all logic within context usings.

* Fixed errors with listing users/players and added slim parameter to players list so you don't get inventory and other heavy data.

* Include class name and map names with players.

* Removing slim parameter because it doesn't do anything.

* Include item, spell, and variable names in api query returns

* Api bug fixes, and error handling when sending emails fail

* API endpoints for name changes and deleting players/accounts

* API endpoints for setting player levels and classes

* Speed up listing/querying by not trying to filter on IEnumerables

EF hashes and caches queries automatically anyways.

* Add config/stats endpoint so that we can get combat stats from the server

* Serialized cached friends as just friends for players

Only send entity stat updates when stats actually change (#625)

Batch projectile and projectile spawn deaths into a singular packet when updating maps (#624)

This line shouldn't exist. It spams clients with npc aggression updates even when the aggression isn't changing (#623)

Reimplementing cps lock (#606)

* Reimplemented cps lock/unlock due to thread.sleep precision (at best) being 15ms.

Locked will be fine 90% of the time but if the server is under extreme load or has insanely large worlds then that 15ms precision could be a problem.

* Load CpsLock property from server config and persist the setting when saved via the cps command

Bug fixes that should be in Prerelease and not stuck in Dev (#605)

* Send quest progress upon quest completion via event. (#575)

* Stop events from getting stuck while changing resolutions with bank/shop/trade/crafting open (#576)

I dropped this (#571)

Merge pull request #570 from AscensionGameDev/devIntoPrerelease

Merging fixes and updates from dev into prerelease

Merge branch 'prerelease' into devIntoPrerelease

Add customizable loop intervals to map sounds (#569)

Pathfinder - Return the path to the closest point found when unable to reach target. (#568)

Fix cpu burning by sleeping instead of yielding on the main server loop (#564)

No need for the loop to iterate 1.8 million times a second for something that only divys out work to other threads.

Fix possible packet error upon logout (#563)

Fixes vital updates by checking for them properly (#562)

Fix server crashes due to deleting characters that remain online and in combat (#553)

* Prevent deleting of online characters.

* Fixed a spelling mishap, and the characters button not working to return to character select

* Disable the characters button on the escape menu while in combat.

* Upon login, instantly load into characters that have been kept online due to combat timers

* Fix user/player/client attachments when logging back into an account that has remained in game due to comabt

* Update Client.cs

Fix animated sprites by calculating which frames to render after setting the animation types (#560)

Fix invulnerability by only blocking damage (instead of damage and healing) (#559)

Fixes 551 by enabling the sticky target preference by default (#558)

Resolves 517 by making spell cast canceling via movement optional (#557)

Enhancement was unintentionally pulled in while merging changes made to Leafling, allowing it as an option (disabled by default) seems to be the best move forward.

Fix control mappings so the same key cannot be mapped for multiple controls (#556)

Also reduces control setting time to 3 seconds before being set to None.. 5 seconds felt way too long.

Fix vital/status updates sending every loop for every entity (#555)

And some status updates not sending at all (time updates/refreshes)

Show target out of range errors (if configured) on warp to spells (#554)

* Fix warp to target spells not being validated by range checks upon cast.

* Show target out of range errors (if configured) on warp to spells

Stops dead entities from switching maps, and stops knocking back dead enemies. (#552)

Fix stat calculations not taking stat buffs on items into account

Fix map items spawning with the same random stat buffs

Fix 515 by not resetting warp/map combobox values initializing editor

Fixes time editor losing new values

Fix animation rendering so that if improper frame counts are provided it cannot render out of bounds textures when using texture packing.

Use a preset color to draw map item names if custom color for the set rarity doesn't exist.

Clone dropchance when cloning items to fix all items dropping 100% of the time.

Fix entity level label not having it's value set.

Loot window item rendering with proper item colors

Fix give experience command editor saving incorrect variable id

Cleanup droppler code and fix map layer selections when using the dropdown

Play resource death animations again

Register packet types within InitNetwork for the editor

Cleaning up packed packets further

This should allow plugin packets to work, pending tests.

Reduce packet sizes by wrapping packets into a class that saves the type as an integer.

Intead of prefixing every packet with a full type name such as the one here:

"Intersect.Network.Packets.Client.AdminActionPacket, Intersect Core, Version=0.7.0.0, Culture=neutral, PublicKeyToken=null"

Clean up new vital update logic

Send vital/status updates each map update as needed instead of on demand to reduce network traffic.

Cleaned up unequip logic slightly.

Auto unequip items that are no equipment, or items we no longer meet conditions for

On Login

On Level Up

On Class Change

Allow unequipping items via events

Fix cooldown group in editor not updating for selected spells

Move MapTileLoc to its own file

Fix npc reset radius not able to be set in the editor

Fix shader not loading on the client

Fix npc forever resetting when it shouldn't

Fix slow map updates due to mismatched timing

Fixes editors not being sent entire set of game content, cleans up caching of game data packet.

Register packet types within InitNetwork for the editor

Cleaning up packed packets further

This should allow plugin packets to work, pending tests.

Reduce packet sizes by wrapping packets into a class that saves the type as an integer.

Intead of prefixing every packet with a full type name such as the one here:

"Intersect.Network.Packets.Client.AdminActionPacket, Intersect Core, Version=0.7.0.0, Culture=neutral, PublicKeyToken=null"

Clean up new vital update logic

Send vital/status updates each map update as needed instead of on demand to reduce network traffic.

Cleaned up unequip logic slightly.

Auto unequip items that are no equipment, or items we no longer meet conditions for

On Login

On Level Up

On Class Change

Allow unequipping items via events

Fix cooldown group in editor not updating for selected spells

Move MapTileLoc to its own file

Fix npc reset radius not able to be set in the editor

Fix shader not loading on the client

Fix npc forever resetting when it shouldn't

Fix slow map updates due to mismatched timing

Fixes editors not being sent entire set of game content, cleans up caching of game data packet.

Merge pull request #487 from AscensionGameDev/devIntoPrerelease

Performance / Optimization Updates into Prerelease

Merge pull request #490 from AscensionGameDev/mainIntoDev

Main into dev

Merge branch 'main' into mainIntoDev

Fixes variable selection in the event change items menu

fix: swallowed exceptions on client startup (#488)

Cleanup and documentation of new logic

Use smart thread pools for map logic, packet handling, and packet sending.

Event lookup caching, variable/condition processing optimizations, player update optimizations

Combat, NPC Logic (Loot Maps!) and Threading Updates

Using more concurrent dictionaries with cached arrays for quicker/threadsafe access.

Stat Calc Fixes

Npc Logic Updates

Disabling Combat Messages

Hotbar Auto Cast if Held Down

Instanced Entity Framework Contexts

- Fixes memory leak where player context would grow forever

- Quicker saving/loading of player and game data

Client QoL & Performance Updates (#476)

* Lidgren upgrades, error surpression, auto mtu negotiation, and using other transmission modes to reduce flooding of reliable channels.

* Map Items Upgrades (ConcurrentDictionary, Loot from Distance, Remove json from packets)

Also upgraded bags so items can be drug into specific slots.

* Event, Npc, and Options Updates

- Change name event command

- Reset Radius for NPCs

- Movement Static for NPCs (Does not allow any movement ever -- target dummies?)

- Remove Max Stat from Options

* Client QoL & Performance Updates

- Auto Target

- Sticky Target

- GWEN Fix (No infinite tooltip elements)

- Static Entity Box

- UI Updates

-- Entity Box Static

-- Enter to nav through event dialogue

-- Esc to close windows

-- Debug Menu update

-- Etc

Event, Npc, and Options Updates (#475)

* Lidgren upgrades, error surpression, auto mtu negotiation, and using other transmission modes to reduce flooding of reliable channels.

* Map Items Upgrades (ConcurrentDictionary, Loot from Distance, Remove json from packets)

Also upgraded bags so items can be drug into specific slots.

* Event, Npc, and Options Updates

- Change name event command

- Reset Radius for NPCs

- Movement Static for NPCs (Does not allow any movement ever -- target dummies?)

- Remove Max Stat from Options

Map Items Upgrades (ConcurrentDictionary, Loot from Distance, Remove json from item update packets) (#474)

* Lidgren upgrades, error surpression, auto mtu negotiation, and using other transmission modes to reduce flooding of reliable channels.

* Map Items Upgrades (ConcurrentDictionary, Loot from Distance, Remove json from packets)

Also upgraded bags so items can be drug into specific slots.

Lidgren upgrades, error surpression, auto mtu negotiation, and using other transmission modes to reduce flooding of reliable channels.

Lock our random object when producing random values.

.Net Framwork 4.6.2 Upgrade + MessagePack Packet Serialization

Merging 6.2 fixes into B7 (#461)

* Don't send cooldown to npcs!

* Bad logic is bad.

* Update Authors.md link to my profile

* Force WorldPos height/width to the Tile Size when no graphic is available

* Force waiting for a server response upon selecting a character.

* Disable the button and re-enable it when no longer waiting for a server response.

* Changes batch 1

* Changes batch 2

* Also disable logout button while waiting for a server response.

* Fix some comment mishaps.

* Do not generate keys on every build

Co-authored-by: Cheshire <azurebeats@hotmail.nl>

Co-authored-by: Robert Lodico <lodico.rj@gmail.com>

Asset compression, encryption and packing changes (#308)

* Add Gzip Compression to Texture Packs.

* Add a basic level of encryption to the compression class.

* Cleaned up some leftover references.

* We should all get more A(ES) in our lives.

I wanted to be rid of the bloody DES warning, and this key is much more fun.

* Add the ability to also encrypt and package up sounds.

* Forgot to include a cache update.

* Add updater support for the new sound packages. Renamed graphics packages to be in line.

* Fix a dumbdumb, add music packing support and some general fixing up

* Comments and a small dispose fix on AssetPacker.

* Make checking for files in an Asset Pack more straightforward, fixed an issue that would stop non-lowercase music to not load from asset packs

* Make asset packing a configurable option with settings in the editor, rather than its own menu option

* Fixing possible case sensitivity issues.

* Fixed a few small issues that were preventing compilation. Stopped creating useless empty directories if packing.

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Co-authored-by: JC Snider <jcsnider3@gmail.com>

Dynamic Map Layers & Extendable Attributes (#379)

* Dynamic Map Layers & Extendable Attributes!

* Custom rendering of the map layer icons based on the dynamic layer config.

* Minor cleanup

* Localize all the config options!

* Localization dictionaries expect the keys to be lowercase it seems.

* Fix error when trying to copy/paste with current layer only enabled

* Resolve double returns

* Interpolation is better than concatenation.

* Use nameof instead of explicit strings for reserved layer names

* It compiles now!

Co-authored-by: Cheshire <azurebeats@hotmail.nl>

Merge pull request #455 from AscensionGameDev/network-plugins

Networking support for plugins

chore: cleanup more jb annotations

Updated examples

Updated scripts, targets

feat: add networking to plugins

Removed JetBrains.Annotations from all core projects

Added plugin networking as needed to projects

- Note: Editor required some changes because of shared interfaces

with the client, but it does not have plugins still

Removed annotations Intersect.Tests

Removed annotations Intersect.Building

Merge pull request #331 from Cheshire92/ChatboxTabs

Add Chatbox tabs and the ability to tag messages with categories.

Fix build

Merge branch 'development' into ChatboxTabs

Merge branch 'development' into ChatboxTabs

Merge branch 'development' into ChatboxTabs

Fix the last commit to work better when there is no channel selected yet upon launch.

Set chat channel depending on tab, remember user set channel for All and System tabs. Fix a potential localization crash should none exist.

Keep enum names consistent..

Cleaned up code, made generating tab buttons generic for easy expansion.

Remove a pointless global leftover, make it clear which tab we're looking at.

Add a TODO for a future PR

I forgot to add admin to the system box. :)

Adds chatbox tabs and all the logic to categorise messages and sort them by tab.

Merge pull request #445 from AscensionGameDev/network-optimizations

Thank you Jon Skeet

Thank you Jon Skeet

Item/Spell Cooldown Groups + Configurable Global Cooldown (#355)

* Add cooldown groups to items and enable them

* Fixed cooldown display and non-group items going on cooldown.

* I don't even know anymore, just end me.

* Changed Cooldown Groups to work like Item/Resource folders do

* Functionality changes

- Added two configuration options to determine whether cooldowns in a cooldown group should match or not. And which cooldown to use when matched. (highest vs current used item)

- Made it so that items not found in the player's inventory also go on cooldown when in the same cooldown group.

* Fix some minor review issues

* Add Spell Cooldown Groups + Group Sharing for Items/Spells

* Adds a configurable global cooldown to items and spells.

* Documentation

* Add option to ignore Global Cooldown for spells/items. Fix migration oopsies.

* Disable Global Cooldown by default to not change game mechanics upon version upgrades

* Fix editor layout

Co-authored-by: lodicolo <lodico.rj@gmail.com>

Allow announcements to show a pop-up on the client-side. (#442)

Add ARGB Color options to Entities and Items (#402)

* Proof of Concept

* Database Migration, Entity prep and NPC Editor changes.

* Add ARGB to items, move Color to Entity class for expandability

* Add event command to change player Color

* Fix color display on CharacterWindow and EntityBox

* Changing to use nameof()

Co-authored-by: lodicolo <lodico.rj@gmail.com>

Map item rework, drawing names on mouse over and a loot window. (#385)

* Add basic map item name drawing

* Fix the render order and generalized some code.

* Only show map items we're mousing over.

* Comment that for some reason didn't count towards the last commit.

* Forgot to add these to make it work on multi-map areas.

* Unnecessary loops are bad M'Kay.

* Completely rewrote MapItem handling to be location based.

* Removed a piece of old test code.

* Add a loot window on the client

* Get rid of some copy/pasta leftovers.

* Abbreviate item name quantities and display them a little different.

* Simplify Loot All, finish up loot window.

* Make display of window configurable, as well as the item count.

* Update MapInstance.cs

* Update PacketHandler.cs

* Fix potential NRE and a small logic error

* Fix a crash when trying to render more items than we're allowed.

* Fix potential issue with equipment and bag drops. Consolidate new drops to existing stacks when configured.

Co-authored-by: JC Snider <jcsnider@users.noreply.github.com>

Item event enhancements + Give Experience event enhancement (#384)

* Add Variable support to ChangeItemCommand

* Add Variable support to GiveExperienceCommand

* Add Variable support to Conditionals HasItem and HasFreeInventorySlots

* Fix an order issue with getting Server Variables by data type

Add options to draw Npc and Player levels next to their names

Merge pull request #441 from lodicolo/fix-439-440

fix: server build on linux, context interface lookup

fix: server build on linux, context interface lookup

Merge pull request #431 from lodicolo/development-fix-linux-building

fix(building): fix build on linux using msbuild/monodevelop

fix(building): fix build on linux using msbuild/monodevelop

Merge pull request #428 from AscensionGameDev/logging-context

feat(logging-db): add logging db with user action history

feat(logging-db): add logging db with user action history

Merge pull request #399 from AscensionGameDev/prerelease-into-dev

Bring the most recent networking fixed into dev

Merge pull request #391 from AscensionGameDev/prerelease-into-dev

Update development branch with fixes and updates made to prerelease.

Compile pl0x

Merge branch 'development' into prerelease-into-dev

Merge pull request #332 from Azurebeats/Fix-77

Add a connection and logged in user cap.

Add a connection and logged in user cap.

Merge pull request #334 from Azurebeats/CustomMouseCursor

Custom Mouse Cursor

Add the ability to set a custom mouse cursor on the client, made a generic method to avoid duplicating code for this.

Merge pull request #327 from AscensionGameDev/merge-prerelease-into-development

Merge prerelease into development

Merge remote-tracking branch 'upstream/prerelease' into development

Merge pull request #312 from AscensionGameDev/merge-prerelease-into-development

Merge prerelease into development

Resolve merge conflicts

fix 267: download data as utf8 to prevent corruption

fix 274: remove cause of NRE

feat 276: add single use for events

fix 284: Do not use Add() for cooldowns

fix 268: check if ban expired

Realized mutes will have the same issue, and fixed those as well

After a ban/mute is selected by user or IP, it is checked to see if it

is expired. If it has been expired, null is returned and it is removed.

chore: additional documentation/cleanup

chore: documentation for GridHelper

chore: cleanup GridHelper

fix 287: common autoscaling grid rendering

Merge pull request #286 from lodicolo/merge-prerelease-into-development

Merge prerelease into development

Merge branch 'prerelease' into merge-prerelease-into-development

Additional error catching

Added example client plugin in Visual Basic .NET

Updated example to latest framework version

Publish fixes

Plugin fixes

- Removed --plugin-development

- Added copy plugin DLL to named directory to targets (not complete fix)

note: not complete because it won't copy non-redundant dependencies, a real solution requires making assembly loading detect and resolve collisions

- Removed redundant includes from targets

- Updated server targets

- Fixed bug in example plugin keeping discord button on all screens

- Added mismatched Assembly detection to manifest loader

Fixed example projects and added commit tag to nuspec

Fix nuspec

Refactored the server to use more OO services, integrated plugin service

Client boostrapper and plugin system

Remaining core changes

Application context/service

Asset/Content types

Cleanup, example client plugin

Additional cleanup and documentation

Cleanup, interface changes/additions

Moved interfaces to the client framework

Move GameStates to Client Framework

Intersect.Client.Framework nuget package

Targets refactor/cleanup

Cleanup, version bump

Disabled deprecated active analysis

Removed large (but unused) deps from Core

Bumped version to 0.7.0.0

Interfaces, minor changes

Analyzers

Manifests and tests

Interfaces, minor changes

References to core interfaces

Core config/context/plugin/service interfaces

Analyzers

Strings, utilities

Minor additions and cleanup

Reference to factory files was missing

Logging cleanup, formatting

Manifests and tests

Changed strings, finished tests for class

Return the max party size to 4 (#222)

Merge pull request #280 from AscensionGameDev/prerelease

Pre-release is the most up-to-date branch, updating development from it